Timestamp Support

tcolvinOH

I noticed something a bit strange that I wanted to report. On the web, in Firefox 61, if I copy entries from a day where no times were logged (pre timestamp support) to today, then attempt to edit the times of the pasted entries (so that I can record an actual time to the new entries), the screen does not seem to accept the changes to the time. The mobile version (Android) lets me make the correction with no problem.

As an experiment, I copied and pasted the entries again, creating two new entries from the ones I copied. I then clicked to edit the time and, without changing the time (displayed current time in the edit fields), clicked on the description of the item. When I did this, the current time displayed in the entry.

It does not appear obvious on how to accept the changes to the time on the web version. I assumed just clicking out of the field would accept whatever changes I keyed in. This was not the case, unless I didnt change the time. Then the time displayed.

I did figure out that if I changed all three fields when editing the time (hours, minutes, AM/PM), that no change is made. If I change only one of the entries (change the hours, minutes, or AM/PM), the time is recorded. It appears that only if I change all three does it fail to record the time.

I can send screenshots if necessary.

Karen_Cronometer

Hi Tim,

Some screenshots would be great! I am trying to reproduce without success

I pasted some items from a non-time stamped day in the past into today. Any clicking on the time stamps field to the left of the food and any or no edits to the current time shown, even all three fields seems to save the time when I click out of the time fields on web, using Firefox 61.

Thanks!

tcolvinOH

I can take a screenshot, but Im not sure its representative, because I believe its based on keystrokes. So here's what I did.

1) Copied two items at the same time (Shift and click two items, Copy selected items).
2) On new day, paste items.
3) Click to select/edit time on first item.
4) Type in the following keystrokes.
a) In hours, type in 09, then hit tab key. this should take you to the minutes field.
b) In minutes, type in 15, then hit the tab key. This should take you to AM/PM field.
c) In AM/PM field, hit A key to change from PM to AM, then hit the tab key. Focus appears to go to the delete timestamp button on the right, which looks greyed out.
d) Click the description.

https://imgur.com/a/lpsb75z

Hopefully this helps. I had to go over it a few times because I couldnt exactly duplicate it again. This sequence describes what I was seeing at the time I reported it.

Karen_Cronometer

Hi Tim,

Thanks so much for the step-by-step instructions. I was using a different set of steps, but can reproduce the issue following your steps. I think it might somehow be linked to using the tab button - but I we will see what the developers think. If I follow your steps then use a mouse click somewhere in the time field it seems to take.

Thanks again!

tcolvinOH

@Karen_Cronometer - Karen, I had a similar experience. It may have something to do with a combination of hitting the tab key and the fact that the sequence takes you from the AM/PM dropdown to the delete button. My guess is that action fires an event that removes the entry.

Karen_Cronometer

@tcolvinOH

We rolled out a fix for this issue last night - give it a try and let me know if it is performing better for you now.

Best,

tcolvinOH

Nope. Same as before. Same exact sequence. Just so Im clear, this was a fix for the web version, correct? I had no issue with the mobile.

Karen_Cronometer

Yes, the fix was on the web version.

Hmm, maybe clear the cache and then log in to your account again to make sure you have the latest version? I am no longer able to reproduce using the same steps.

A picture of my cat might help:

tcolvinOH

Interesting. Perhaps I dont have the change yet. I performed all of those steps, but it seems that whenever I tab out of the AM/PM field, focus goes to the delete button to the right. If I then click on the description, the change I made is not there. It still acts as if its removing the time. If you look at the screen shot I sent you, when you tab from the AM/PM field, a little gray dotted square box surrounds the delete button. thats when I click in the description field.

I did clear my cache and logged out and back in. I will attempt it again at some point when I have a moment to see if anything changes.

Your cat is adorable.

tcolvinOH

I just tried again and still no dice. So I thought Id give it a whirl in Chrome. When I tried it in Chrome, once I tabbed out of the AM/PM field, the time edit went away and it accepted my time change, instead of tabbing to the delete button, like it seems to want to do in FF.

I wish I had better information to give you, but I cant really debug the pages to tell you exactly what is happening.

Karen_Cronometer

That helps - thank you! It was my mistake - I forgot to test in Firefox and you are absolutely right. We will keep working on this one.

Cheers,

tcolvinOH

I just did something very similar on a project Im working on at work. Made a program change, tested and forgot to test another combination. Easy to miss.

tcolvinOH

Was another change made? Seems like FF responds similarly to how I described Chrome when I tested it last. I did most of my food entry on my phone last week and didnt check to see if this had changed until yesterday. Seems to be working better.

I think if I have focus on the AM/PM field and I then click out of the field (such as on the description), it still isnt working, but tabbing through the fields seems to be working better.

Karen_Cronometer

@tcolvinOH

We did implement some changes to get it working on Firefox as well.

Can you describe how you are focusing on the AM/PM field? Are you editing a food that already has a time stamp and clicking on AM/PM field directly to change it, then clicking away from the timestamp?

Thanks!

tcolvinOH

@Karen_Cronometer - When I originally reported the problem, I had copied over a couple of items that did not have time stamps (they were created before Timestamp support was implemented). I dont recall if Ive tested clicking directly in the field. I believe previously I had tabbed to it, but I believe I attempted to just change the AM/PM field by clicking in it.

While writing this, I attempted the following sequence:

So if the time doesnt exist and you click in the time area, initial focus is on "hours" (which you would see a blinking cursor, usually). Without changing the value of hours currently present and I I directly click AM/PM and change its value (so if its AM, Im changing to PM, and vice versa), then click out of the field (by clicking on the description), the time is not recorded. It does seem to record the AM/PM change if a time exists, using the same sequence. So if a time exists, and I perform the same steps above, the change appears to be recorded.

Certainly an interesting sequence of events.

Karen_Cronometer

@timcolvin

Thanks for the description. We will continue to work on this!

Best,

tcolvinOH

No problem. I do this kind of thing every day. Good to see we're making some headway with it.

tcolvinOH

Maybe I should stop looking at this thing. LOL.

So this morning while entering in some biometrics that I didnt log right away, I noticed that when I went to edit the time, the "Add Measurement" button shifted to the right. If I went to edit the time and click the button to add the measurement, first, the buttom moved back to the center. Then I had to click the button again in order to record the entry.

https://imgur.com/a/ZThB6lM

Karen_Cronometer

Thanks tcolvinOH! I have reported a bug for this layout issue.

Cheers,